Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ELM JSON reader and writer (Kotlin feature branch) #1489

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

antvaset
Copy link
Contributor

@antvaset antvaset commented Jan 16, 2025

What's included:

  • QNames are serialized in JSON as strings formatted as {NAMESPACE_URI}LOCAL_PART, consistent with JAXB + MOXy. Uses a subclassed QNameSerializer with a modified serial descriptor.
  • BigDecimals are serialized in JSON as numbers and not strings, consistent with JAXB + MOXy. Relies on contextual serialization.
  • Initial code consolidation and cleanup.

Remaining tasks:

  • Handling ELM annotations which are typed as java.io.Serializable.

Copy link

Formatting check succeeded!

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.24%. Comparing base (b5a62e8) to head (f9168c2).
Report is 1 commits behind head on feature-kotlin.

Additional details and impacted files
@@                Coverage Diff                @@
##             feature-kotlin    #1489   +/-   ##
=================================================
  Coverage             68.24%   68.24%           
+ Complexity             4786     4785    -1     
=================================================
  Files                   461      463    +2     
  Lines                 27496    27484   -12     
  Branches               5264     5264           
=================================================
- Hits                  18764    18756    -8     
+ Misses                 6575     6571    -4     
  Partials               2157     2157           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
72.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@JPercival JPercival merged commit 4479b47 into feature-kotlin Jan 16, 2025
5 of 6 checks passed
@JPercival JPercival deleted the feature-kotlin-json-serializer branch January 16, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants