Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break out UCUM Service into its own module #1471

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

JPercival
Copy link
Contributor

No description provided.

Copy link

Formatting check succeeded!

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.

Project coverage is 65.91%. Comparing base (b4dd0fa) to head (aa95040).
Report is 1 commits behind head on feature-kotlin.

Files with missing lines Patch % Lines
...cqframework/cql/cql2elm/ucum/UcumServiceFactory.kt 0.00% 2 Missing and 1 partial ⚠️
...ava/org/cqframework/cql/ucum/DefaultUcumService.kt 81.25% 3 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             feature-kotlin    #1471   +/-   ##
=================================================
  Coverage             65.91%   65.91%           
- Complexity             4859     4860    +1     
=================================================
  Files                   487      489    +2     
  Lines                 28780    28785    +5     
  Branches               5433     5433           
=================================================
+ Hits                  18970    18974    +4     
  Misses                 7593     7593           
- Partials               2217     2218    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JPercival JPercival merged commit 82823a8 into feature-kotlin Dec 16, 2024
3 checks passed
@JPercival JPercival deleted the feature-break-out-ucum branch December 16, 2024 20:51
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
69.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants