Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite String escaping #1468

Merged
merged 5 commits into from
Dec 13, 2024
Merged

Rewrite String escaping #1468

merged 5 commits into from
Dec 13, 2024

Conversation

JPercival
Copy link
Contributor

  • Rewrite of the StringEscapeUtils to remove dependency on Apache Commons

Copy link

Formatting check succeeded!

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 4 lines in your changes missing coverage. Please review.

Project coverage is 65.91%. Comparing base (a021ffa) to head (9d7bc25).
Report is 2 commits behind head on feature-kotlin.

Files with missing lines Patch % Lines
...a/org/cqframework/cql/cql2elm/StringEscapeUtils.kt 87.87% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##             feature-kotlin    #1468      +/-   ##
====================================================
- Coverage             65.92%   65.91%   -0.02%     
- Complexity             4853     4859       +6     
====================================================
  Files                   487      487              
  Lines                 28791    28782       -9     
  Branches               5428     5434       +6     
====================================================
- Hits                  18981    18971      -10     
+ Misses                 7595     7593       -2     
- Partials               2215     2218       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JPercival JPercival merged commit 7d902ee into feature-kotlin Dec 13, 2024
3 checks passed
@JPercival JPercival deleted the remove-commons branch December 13, 2024 20:27
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
69.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants