Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests to ensure generic overloads are sufficiently specified #1249

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Tests to ensure generic overloads are sufficiently specified #1249

merged 3 commits into from
Oct 24, 2023

Conversation

JPercival
Copy link
Contributor

  • Adds tests to ensure that the compiler emits multiple levels of type specifiers when there are generic overloads.

lukedegruchy
lukedegruchy reviewed Oct 13, 2023
View reviewed changes
Src/java/cql-to-elm/src/test/java/org/cqframework/cql/cql2elm/GenericOverloadsTests.java
}

@Test
public void TestNoResultTypesSignatureNone() throws IOException {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For completeness I suggest doing the same for the other 2 signature types, and consider doing this as part a parameterized test.

lukedegruchy
lukedegruchy approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@lukedegruchy lukedegruchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one suggestion.

@JPercival JPercival enabled auto-merge (squash) October 24, 2023 20:24
@JPercival JPercival merged commit 74deaeb into master Oct 24, 2023
@JPercival JPercival deleted the test-result-types branch October 24, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdnazmulkarim mdnazmulkarim mdnazmulkarim approved these changes

@lukedegruchy lukedegruchy lukedegruchy approved these changes

@brynrhodes brynrhodes Awaiting requested review from brynrhodes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JPercival @lukedegruchy @mdnazmulkarim