Refactoring #13
Open
Refactoring #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: solidnerd <[email protected]>
Signed-off-by: solidnerd <[email protected]>
The behaviour before was two use 2 seprated layers and that didn’t work when you are trying to remove something from the layer below your current layer. Because every layer under your current layer is readonly. Signed-off-by: solidnerd <[email protected]>
Signed-off-by: solidnerd <[email protected]>
Signed-off-by: solidnerd <[email protected]>
Signed-off-by: solidnerd <[email protected]>
|
Nice work! |
|
Thanks :) |
|
Can't you get this even smaller by using multi-stage build and just copy the resulting compiled binary to a new image? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @cptactionhank ,
thanks for your work on this awesome image. I tried it out and it works directly out of the box. I did some refactoring to the Dockerfile this resulted in a smaller image size because the problem of your current Dockerfile is that you are trying to remove something for an another layer and this doesn't work. The
netatalkimage is your builded image from your current Dockerfile from master. I did some refactorings and now we got only217.9MB on my refactored image.WDYT ?