Add support for RPM compatible version compare #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcbaker
changed the title
This uses a library that I'd written for another project that implements RPM compatible version comparisons. TODO: needs some tests TODO: rpm-version cmake support needs to land
dcbaker
force-pushed
the
submit/rpm-compatible-version
branch
from
0cee50e
to
51e60f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a library that implements RPM compatible version comparisons, which I had written for use in two different previous projects (a pkg-config library I had been considering and a C++ implementation of Meson). The library itself is pretty simple, but not having another implementation of RPM-compatible version compare seems very desirable to me.
We would need to have better cmake support for fetch content in rpm-version, and we would need to wire this into the CMake build. which leads me to the other question I have, do we want to allow building without rpm-version support? I've currently wired it up as optional, and I see value in that since some people may not care about rpm compatible version comparisons and it is one less dependency. On the other hand it simplifies our process a lot of we can just assume there is rpm support.
TODO: needs some tests
TODO: rpm-version cmake support needs to land (dcbaker/rpm-version#8)