Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unused const variable/verbose_print warning #767

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Avoid unused const variable/verbose_print warning #767

merged 1 commit into from
Mar 14, 2024

Conversation

hfp
Copy link
Member

@hfp hfp commented Mar 13, 2024

  • Almost false positive aka incorrect warning.
  • Shall be fixed regardless.

@alazzaro
Copy link
Member

alazzaro commented Mar 13, 2024 •
edited
Loading

@hfp no sure I understand your change. Originally that function didn't exist with HIP on AMD. I think it exists now so we can remove the entire condition...

@alazzaro
Copy link
Member

alazzaro commented Mar 13, 2024 •
edited
Loading

Correction, it is still not supported with HIP on AMD.

But then the proper condition should include NVIDIA too, something like:

#if defined(__CUDA) || defined(__HIP_PLATFORM_NVCC__)

and you can directly remove the entire static variable definition...

alazzaro
alazzaro reviewed Mar 13, 2024
View reviewed changes
Copy link
Member

@alazzaro alazzaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

follow-up to my last comment, I think we can simplify the code even further...

src/acc/cuda_hip/acc_dev.cpp Outdated Show resolved Hide resolved
src/acc/cuda_hip/acc_dev.cpp Show resolved Hide resolved
@hfp hfp merged commit d861f35 into cp2k:develop Mar 14, 2024
23 checks passed
@hfp
Copy link
Member Author

hfp commented Apr 3, 2024

This PR seems to cause:

CUDA RUNTIME API error: DeviceSetLimit failed with error cudaErrorInvalidValue.

( tested on H100 device )

@hfp hfp mentioned this pull request Apr 3, 2024
Open
@alazzaro
Copy link
Member

alazzaro commented Apr 3, 2024

Is this only H100? Maybe something has changed there?

@hfp
Copy link
Member Author

hfp commented Apr 3, 2024

I am investigating the issue under #776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alazzaro alazzaro alazzaro left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hfp @alazzaro