Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix repo imports and add devcontainer #88

Merged
merged 7 commits into from
Jun 14, 2024
Merged

chore: fix repo imports and add devcontainer #88

merged 7 commits into from
Jun 14, 2024

Conversation

mfw78
Copy link
Contributor

@mfw78 mfw78 commented Jun 11, 2024

Description

Recently some upstream submodules were deleted which resulted in the head branch breaking.

Specifically, these were:

These are mostly used in the course of testing. There have also been issues caused in other development associated with ComposableCoW (a.k.a programmatic orders framework) with the large amount of dependencies / git submodule treatment of such.

Changes

  • Added a devcontainer for quality of life improvement
  • Removed aforementioned submodules
  • Added new cowprotocol module targeting main branch of upstream to take advantage of contracts already having had their pragma bumped 🚀
  • Refactored all contracts to make all imports explicit - eliminating annoying IERC20 conflicts
  • Removed safe module referencing https://github.com/rndlabs and now targets https://github.com/cowdao-grants/extensible-fallback-handler

How to test

  1. CI/CD
  2. Observe no logic changes in code - only specific import changes

@mfw78 mfw78 requested a review from fedgiac June 11, 2024 13:38
@mfw78 mfw78 self-assigned this Jun 11, 2024
@mfw78
Copy link
Contributor Author

mfw78 commented Jun 14, 2024

Merging with 1x approval due no logic changes (imports only)

@mfw78 mfw78 merged commit 24d556b into main Jun 14, 2024
2 checks passed
@mfw78 mfw78 deleted the imports-clean branch June 14, 2024 08:03
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants