Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: standardise openzeppelin import path #61

Merged
merged 4 commits into from
Sep 3, 2023
Merged

Conversation

mfw78
Copy link
Contributor

@mfw78 mfw78 commented Sep 2, 2023

Problem

When developing integrations, most libraries that import openzeppelin contracts do so using npm scope (ie. @openzeppelin/contracts). Using non-standard import paths can create complexities with dependency management / remappings.

Solution

For openzeppelin, standardise around the use of @openzeppelin/contracts so those building on top of these repositories don't have the aforementioned problems.

@mfw78 mfw78 added the D-chore label Sep 2, 2023
@mfw78 mfw78 requested a review from fleupold September 2, 2023 13:09
@mfw78 mfw78 self-assigned this Sep 2, 2023
Copy link
Contributor

@fleupold fleupold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfw78 mfw78 merged commit 3151391 into develop Sep 3, 2023
1 check passed
@mfw78 mfw78 deleted the fix-openzeppelin-path branch September 3, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants