improve patch result

coverbot-io · Sep 1, 2023 · 05a4e7b · 05a4e7b
1 parent eed021d
commit 05a4e7b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/dist/index.js b/dist/index.js
@@ -11824,7 +11824,7 @@ const getChangedFiles = (octokit) => __awaiter(void 0, void 0, void 0, function*
             patch = atob(encodedContent);
         }
         const changedLines = patch.split("\n").filter(line => line.startsWith("+"));
-        return Object.assign(Object.assign({}, acc), { [file.filename]: changedLines });
+        return Object.assign(Object.assign({}, (yield acc)), { [file.filename]: changedLines });
     }), {});
 });
 exports.getChangedFiles = getChangedFiles;
@@ -11922,7 +11922,7 @@ function run() {
                 }
                 octokit.rest.checks.update(Object.assign(Object.assign({}, github.context.repo), { check_run_id: checkRun.id, conclusion: res.result.state }));
                 if (relevantForPatch && relevantForPatch > 0) {
-                    octokit.rest.repos.createCommitStatus(Object.assign(Object.assign({}, github.context.repo), { sha: res.result.sha, state: coveredForPatch === relevantForPatch ? "success" : "failure", context: "coverbot (patch)", description: `${coveredForPatch} lines covered out of ${relevantForPatch} (${patchPercentage}%)` }));
+                    octokit.rest.repos.createCommitStatus(Object.assign(Object.assign({}, github.context.repo), { sha: res.result.sha, state: Number(patchPercentage) >= Number(percentage) ? "success" : "failure", context: "coverbot (patch)", description: `${coveredForPatch} lines covered out of ${relevantForPatch} (${patchPercentage}%)` }));
                 }
             }
         }

diff --git a/src/changed-files.ts b/src/changed-files.ts
@@ -30,6 +30,6 @@ export const getChangedFiles = async (
 
       const changedLines = patch.split("\n").filter(line => line.startsWith("+"))
 
-      return { ...acc, [file.filename]: changedLines } as ChangedFiles
+      return { ...(await acc), [file.filename]: changedLines } as ChangedFiles
     }, {})
 }
diff --git a/src/main.ts b/src/main.ts
@@ -95,7 +95,7 @@ async function run(): Promise<void> {
         octokit.rest.repos.createCommitStatus({
           ...github.context.repo,
           sha: res.result.sha,
-          state: coveredForPatch === relevantForPatch ? "success" : "failure",
+          state: Number(patchPercentage) >= Number(percentage) ? "success" : "failure",
           context: "coverbot (patch)",
           description: `${coveredForPatch} lines covered out of ${relevantForPatch} (${patchPercentage}%)`,
         })