Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(quantic): Dropdown alignment issue in quanticSort component #4351

Merged
merged 5 commits into from
Aug 30, 2024

Conversation

SimonMilord
Copy link
Contributor

@SimonMilord SimonMilord commented Aug 28, 2024

SFINT-5687

ISSUE:

  • On smaller screens width, the dropdown for the quantic sort was partially hidden:
image

SOLUTION:

  • Added a dropdown-alignment= "auto" prop to the lightning-combobox in the quanticSort component. This overrides the default Salesforce alignment value for the dropdown of : LEFT

It will now automatically align the dropdown based on the space available for the dropdown which should make it responsive no matter the screen size.

DEMO:

Screen.Recording.2024-08-28.at.4.08.00.PM.mov

@SimonMilord SimonMilord requested a review from a team as a code owner August 28, 2024 20:09
Copy link

github-actions bot commented Aug 28, 2024

Pull Request Report

PR Title

❌ Title should follow the conventional commit spec:
<type>(optional scope): <description>

Example: feat(headless): add result-list controller

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 244.3 244.3 0
commerce 344.3 344.3 0
search 418.1 418.1 0
insight 394.7 394.7 0
product-listing 308.6 308.6 0
product-recommendation 215.2 215.2 0
recommendation 258.1 258.1 0
ssr 408 408 0
ssr-commerce 354.9 354.9 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

Copy link
Collaborator

@erocheleau erocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if it breaks in the future :D

@SimonMilord SimonMilord added this pull request to the merge queue Aug 30, 2024
Merged via the queue into master with commit cd26983 Aug 30, 2024
117 checks passed
@SimonMilord SimonMilord deleted the SFINT-5687 branch August 30, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants