Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(headless, atomic, quantic)!: remove deprecated functions/properties #4350

Merged
merged 17 commits into from
Sep 17, 2024

Conversation

fpbrault
Copy link
Contributor

@fpbrault fpbrault commented Aug 28, 2024

This PR removes deprecated functions and properties.

It includes changes to atomic-category-facet and the equivalent in quantic as the parents and values properties have been replaced with valuesAsTrees and selectedValueAncestry

It also includes changes to atomic-react properties and the removal of the two deprecated components in atomic-hosted-page.

https://coveord.atlassian.net/browse/KIT-2379

@fpbrault fpbrault added the v3 label Aug 28, 2024
@fpbrault fpbrault changed the title feat(headless, atomic)!: remove deprecated functions chore(headless, atomic)!: remove deprecated functions Aug 28, 2024
Copy link

github-actions bot commented Aug 28, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 241.4 241.4 0
commerce 339.5 339.5 0
search 409.8 409.8 0
insight 394.6 394.6 0
recommendation 252.5 252.5 0
ssr 403.5 403.5 0
ssr-commerce 351.7 351.7 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@fpbrault fpbrault changed the title chore(headless, atomic)!: remove deprecated functions chore(headless, atomic, quantic)!: remove deprecated functions Aug 29, 2024
@fpbrault fpbrault changed the title chore(headless, atomic, quantic)!: remove deprecated functions chore(headless, atomic, quantic)!: remove deprecated functions/properties Aug 29, 2024
@fpbrault fpbrault added this to the V3 milestone Aug 29, 2024
@fpbrault fpbrault marked this pull request as ready for review August 29, 2024 23:17
@fpbrault fpbrault requested review from a team as code owners August 29, 2024 23:17
packages/headless/src/utils/utils.ts Outdated Show resolved Hide resolved
packages/headless/src/app/engine.ts Outdated Show resolved Hide resolved
@alexprudhomme alexprudhomme enabled auto-merge (squash) September 17, 2024 13:34
@alexprudhomme alexprudhomme merged commit 8de5406 into master Sep 17, 2024
117 checks passed
@alexprudhomme alexprudhomme deleted the KIT-2379 branch September 17, 2024 14:08
fpbrault added a commit that referenced this pull request Sep 17, 2024
…ties (#4350)

This PR removes deprecated functions and properties. It also removes
some atomic-react properties and big changes in atomic-hosted-page.

It includes changes to `atomic-category-facet` and the equivalent in
quantic as the `parents` and `values` properties have been replaced with
`valuesAsTrees` and `selectedValueAncestry`

https://coveord.atlassian.net/browse/KIT-2379

---------

Co-authored-by: Alex Prudhomme <[email protected]>
Co-authored-by: Frederic Beaudoin <[email protected]>
fpbrault added a commit that referenced this pull request Sep 17, 2024
…ties (#4350)

This PR removes deprecated functions and properties. It also removes
some atomic-react properties and big changes in atomic-hosted-page.

It includes changes to `atomic-category-facet` and the equivalent in
quantic as the `parents` and `values` properties have been replaced with
`valuesAsTrees` and `selectedValueAncestry`

https://coveord.atlassian.net/browse/KIT-2379

---------

Co-authored-by: Alex Prudhomme <[email protected]>
Co-authored-by: Frederic Beaudoin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants