-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(headless, atomic, quantic)!: remove deprecated functions/properties #4350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpbrault
changed the title
feat(headless, atomic)!: remove deprecated functions
chore(headless, atomic)!: remove deprecated functions
Aug 28, 2024
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
fpbrault
changed the title
chore(headless, atomic)!: remove deprecated functions
chore(headless, atomic, quantic)!: remove deprecated functions
Aug 29, 2024
fpbrault
changed the title
chore(headless, atomic, quantic)!: remove deprecated functions
chore(headless, atomic, quantic)!: remove deprecated functions/properties
Aug 29, 2024
fpbrault
requested review from
olamothe,
louis-bompart,
fbeaudoincoveo,
erocheleau,
SimonMilord and
mmitiche
August 29, 2024 23:17
alexprudhomme
approved these changes
Aug 30, 2024
alexprudhomme
assigned louis-bompart and alexprudhomme and unassigned alexprudhomme and louis-bompart
Sep 16, 2024
alexprudhomme
temporarily deployed
to
PR Artifacts
September 16, 2024 20:28
— with
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
PR Artifacts
September 16, 2024 20:47
— with
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
PR Artifacts
September 16, 2024 21:55
— with
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
PR Artifacts
September 17, 2024 12:27
— with
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
PR Artifacts
September 17, 2024 13:28
— with
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
PR Artifacts
September 17, 2024 13:44
— with
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
PR Artifacts
September 17, 2024 14:08
— with
GitHub Actions
Inactive
fpbrault
added a commit
that referenced
this pull request
Sep 17, 2024
…ties (#4350) This PR removes deprecated functions and properties. It also removes some atomic-react properties and big changes in atomic-hosted-page. It includes changes to `atomic-category-facet` and the equivalent in quantic as the `parents` and `values` properties have been replaced with `valuesAsTrees` and `selectedValueAncestry` https://coveord.atlassian.net/browse/KIT-2379 --------- Co-authored-by: Alex Prudhomme <[email protected]> Co-authored-by: Frederic Beaudoin <[email protected]>
fpbrault
added a commit
that referenced
this pull request
Sep 17, 2024
…ties (#4350) This PR removes deprecated functions and properties. It also removes some atomic-react properties and big changes in atomic-hosted-page. It includes changes to `atomic-category-facet` and the equivalent in quantic as the `parents` and `values` properties have been replaced with `valuesAsTrees` and `selectedValueAncestry` https://coveord.atlassian.net/browse/KIT-2379 --------- Co-authored-by: Alex Prudhomme <[email protected]> Co-authored-by: Frederic Beaudoin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes deprecated functions and properties.
It includes changes to
atomic-category-facet
and the equivalent in quantic as theparents
andvalues
properties have been replaced withvaluesAsTrees
andselectedValueAncestry
It also includes changes to atomic-react properties and the removal of the two deprecated components in atomic-hosted-page.
https://coveord.atlassian.net/browse/KIT-2379