Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setup v2 legacy releases #4319

Merged
merged 1 commit into from
Aug 28, 2024
Merged

chore: setup v2 legacy releases #4319

merged 1 commit into from
Aug 28, 2024

Conversation

louis-bompart
Copy link
Collaborator

Ready for review.
After the last v2 feature release:

  • rebase v2 onto the last v2 release commit
  • merge this branch

https://coveord.atlassian.net/browse/KIT-3466

@louis-bompart louis-bompart requested review from a team as code owners August 26, 2024 19:17
@louis-bompart louis-bompart requested review from olamothe, y-lakhdar, fbeaudoincoveo, erocheleau, SimonMilord and mmitiche and removed request for a team August 26, 2024 19:17
Copy link

github-actions bot commented Aug 26, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 244.1 244.1 0
commerce 342.7 342.7 0
search 415.7 415.7 0
insight 392.4 392.4 0
product-listing 306.4 306.4 0
product-recommendation 214.9 214.9 0
recommendation 257.3 257.3 0
ssr 405.7 405.7 0
ssr-commerce 353.3 353.3 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

Copy link
Contributor

@mmitiche mmitiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

github-merge-queue bot pushed a commit that referenced this pull request Aug 28, 2024
Akin to #4319 , but for the mainline: We now use the release/v3 branch
as the tag for "where's the latest v3"

https://coveord.atlassian.net/browse/KIT-3497
@louis-bompart louis-bompart merged commit c783d65 into v2 Aug 28, 2024
115 checks passed
@louis-bompart louis-bompart deleted the chore/KIT-3466 branch August 28, 2024 15:18
@louis-bompart louis-bompart mentioned this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants