-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(headless): expose user action controller in insight bundle and add logOpenUser analytics action #4296
Conversation
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support product-recommendation : missing SSR support product-listing : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
packages/headless/src/features/analytics/search-action-cause.ts
Outdated
Show resolved
Hide resolved
packages/headless/src/features/insight-user-actions/insight-user-actions-loader.ts
Show resolved
Hide resolved
packages/headless/src/features/insight-search/insight-analytics-actions.ts
Show resolved
Hide resolved
7d81011
to
ffc2320
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some clarity in the code could be improved
packages/headless/src/features/insight-search/insight-analytics-actions.test.ts
Outdated
Show resolved
Hide resolved
packages/headless/src/features/insight-user-actions/insight-user-actions-loader.ts
Outdated
Show resolved
Hide resolved
packages/headless/src/controllers/insight/user-actions/headless-user-actions.ts
Show resolved
Hide resolved
packages/headless/src/features/insight-search/insight-analytics-actions.ts
Show resolved
Hide resolved
packages/headless/src/features/insight-search/insight-analytics-actions.test.ts
Show resolved
Hide resolved
packages/headless/src/controllers/insight/user-actions/headless-user-actions.ts
Outdated
Show resolved
Hide resolved
72c7462
to
ab01298
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
SFINT-5640
IN THIS PR:
logOpenUserActions
analytics eventlogOpenUserActions
actionTests: