Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(headless): expose user action controller in insight bundle and add logOpenUser analytics action #4296

Merged
merged 10 commits into from
Aug 30, 2024

Conversation

SimonMilord
Copy link
Contributor

@SimonMilord SimonMilord commented Aug 19, 2024

SFINT-5640

IN THIS PR:

  • Added logOpenUserActions analytics event
  • Exposed the User actions controller in the insight bundle
  • Added unit tests for the logOpenUserActions action

Tests:

image

Copy link

github-actions bot commented Aug 19, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 244.1 244.1 0
commerce 342.7 342.7 0
search 415.7 415.7 0
insight 392.4 396 0.9
product-listing 306.4 306.4 0
product-recommendation 214.9 214.9 0
recommendation 257.3 257.3 0
ssr 405.7 405.7 0
ssr-commerce 353.3 353.3 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@SimonMilord SimonMilord marked this pull request as ready for review August 27, 2024 17:51
Copy link
Collaborator

@erocheleau erocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some clarity in the code could be improved

Copy link
Collaborator

@erocheleau erocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@mmitiche mmitiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SimonMilord SimonMilord added this pull request to the merge queue Aug 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 30, 2024
@SimonMilord SimonMilord added this pull request to the merge queue Aug 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 30, 2024
@SimonMilord SimonMilord added this pull request to the merge queue Aug 30, 2024
Merged via the queue into master with commit 2299887 Aug 30, 2024
117 checks passed
@SimonMilord SimonMilord deleted the SFINT-5640 branch August 30, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants