Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(headless commerce react samples): Add instant products #4256

Merged
merged 15 commits into from
Aug 28, 2024
Merged

docs(headless commerce react samples): Add instant products #4256

merged 15 commits into from
Aug 28, 2024

Conversation

fbeaudoincoveo
Copy link
Contributor

@fbeaudoincoveo fbeaudoincoveo requested a review from a team as a code owner August 6, 2024 12:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2024 •
edited
Loading

Pull Request Report

PR Title

❌ Title should follow the conventional commit spec:
<type>(optional scope): <description>

Example: feat(headless): add result-list controller

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 244.1 244.1 0
commerce 341.8 341.8 0
search 415.6 415.6 0
insight 392.3 392.3 0
product-listing 306.4 306.4 0
product-recommendation 214.9 214.9 0
recommendation 257.2 257.2 0
ssr 405.6 405.6 0
ssr-commerce 351.6 351.6 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

fpbrault
fpbrault approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@fpbrault fpbrault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fbeaudoincoveo fbeaudoincoveo added this pull request to the merge queue Aug 27, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 27, 2024
@fbeaudoincoveo
docs(headless commerce react samples): Add instant products (#4256)
0f7eede 
https://coveord.atlassian.net/browse/KIT-3431
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 27, 2024
@fbeaudoincoveo fbeaudoincoveo added this pull request to the merge queue Aug 27, 2024
@louis-bompart louis-bompart removed this pull request from the merge queue due to the queue being cleared Aug 27, 2024
@fbeaudoincoveo fbeaudoincoveo added this pull request to the merge queue Aug 27, 2024
@louis-bompart louis-bompart removed this pull request from the merge queue due to the queue being cleared Aug 27, 2024
@fbeaudoincoveo fbeaudoincoveo added this pull request to the merge queue Aug 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 27, 2024
@fbeaudoincoveo fbeaudoincoveo added this pull request to the merge queue Aug 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 27, 2024
@fbeaudoincoveo fbeaudoincoveo added this pull request to the merge queue Aug 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 27, 2024
@fbeaudoincoveo fbeaudoincoveo added this pull request to the merge queue Aug 28, 2024
Merged via the queue into master with commit e62f91d Aug 28, 2024
112 checks passed
@fbeaudoincoveo fbeaudoincoveo deleted the KIT-3431 branch August 28, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexprudhomme alexprudhomme alexprudhomme approved these changes

@Spuffynism Spuffynism Spuffynism approved these changes

@fpbrault fpbrault fpbrault approved these changes

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/search

@louis-bompart louis-bompart Awaiting requested review from louis-bompart louis-bompart is a code owner automatically assigned from coveo/search

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fbeaudoincoveo @fpbrault @Spuffynism @louis-bompart @alexprudhomme