Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update some dependencies #4168

Closed
wants to merge 19 commits into from
Closed

chore(deps): update some dependencies #4168

wants to merge 19 commits into from

Conversation

alexprudhomme
Copy link
Contributor

@alexprudhomme alexprudhomme commented Jul 9, 2024 •
edited
Loading

https://coveord.atlassian.net/browse/KIT-282

did it myself to replace #3795. renovate doesnt work well when the pr stays up. The dependency table is desynced and I kept getting a bunch of errors.

@developer-experience-bot
Copy link
Contributor

developer-experience-bot bot commented Jul 9, 2024 •
edited
Loading

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 244.9 244.9 0
commerce 339.5 339.5 0
search 411.8 411.8 0
insight 391.9 391.9 0
product-listing 306.6 306.6 0
product-recommendation 211.2 211.2 0
recommendation 258 258 0
ssr 404.3 404.3 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@alexprudhomme alexprudhomme changed the title chore(deps): some dependencies chore(deps): update some dependencies Jul 9, 2024
@alexprudhomme alexprudhomme marked this pull request as ready for review July 9, 2024 20:30
@alexprudhomme alexprudhomme requested a review from a team as a code owner July 9, 2024 20:30
louis-bompart
louis-bompart reviewed Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall, good idea. However let's tread carefuly around some of them,

packages/headless/package.json Show resolved Hide resolved
utils/release/package.json Outdated Show resolved Hide resolved
@alexprudhomme
downgrade playwright
de3a368 
https://coveord.atlassian.net/browse/KIT-282

Revert "downgrade playwright"

This reverts commit bc5d3a4.

Revert "Update package-lock.json"

This reverts commit 2e71800.

Update package-lock.json

https://coveord.atlassian.net/browse/KIT-282

fix eslint stuff

https://coveord.atlassian.net/browse/KIT-282
@alexprudhomme
Revert "Merge branch 'KIT-282-deps' of https://github.com/coveo/ui-kit …
2573e32 
…into KIT-282-deps"

This reverts commit 16ea8c5, reversing
changes made to b1156a2.
@alexprudhomme
Reapply "Update dependency-review.yml"
933f1f3 
This reverts commit 899bc3d.
@alexprudhomme
Revert "merge"
09c2e13 
This reverts commit 0a40c96, reversing
changes made to 899bc3d.
@alexprudhomme alexprudhomme requested review from a team as code owners July 12, 2024 17:47
@alexprudhomme
Copy link
Contributor Author

im done fighting this is a waste of time. bunch of problems

@louis-bompart louis-bompart deleted the KIT-282-deps branch August 26, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-bompart louis-bompart louis-bompart left review comments

@olamothe olamothe olamothe approved these changes

@fpbrault fpbrault Awaiting requested review from fpbrault fpbrault is a code owner automatically assigned from coveo/search

@fbeaudoincoveo fbeaudoincoveo Awaiting requested review from fbeaudoincoveo fbeaudoincoveo is a code owner automatically assigned from coveo/search

@erocheleau erocheleau Awaiting requested review from erocheleau erocheleau is a code owner automatically assigned from coveo/salesforce-integration

@SimonMilord SimonMilord Awaiting requested review from SimonMilord SimonMilord is a code owner automatically assigned from coveo/salesforce-integration

@mmitiche mmitiche Awaiting requested review from mmitiche mmitiche is a code owner automatically assigned from coveo/salesforce-integration

@mikegron mikegron Awaiting requested review from mikegron mikegron is a code owner automatically assigned from coveo/service-integrations

@dguerinCoveo dguerinCoveo Awaiting requested review from dguerinCoveo dguerinCoveo is a code owner automatically assigned from coveo/service-integrations

@pathiery pathiery Awaiting requested review from pathiery pathiery is a code owner automatically assigned from coveo/service-integrations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexprudhomme @olamothe @louis-bompart