Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(atomic): fix commerce tests #4160

Merged
merged 8 commits into from
Jul 9, 2024
Merged

test(atomic): fix commerce tests #4160

merged 8 commits into from
Jul 9, 2024

Conversation

olamothe
Copy link
Member

@olamothe olamothe commented Jul 8, 2024

@olamothe olamothe requested a review from a team as a code owner July 8, 2024 15:01
@developer-experience-bot
Copy link
Contributor

developer-experience-bot bot commented Jul 8, 2024 •
edited
Loading

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 205.9 205.9 0
commerce 300.3 300.3 0
search 374.8 374.8 0
insight 354.9 354.9 0
product-listing 267.5 267.5 0
product-recommendation 172.1 172.1 0
recommendation 218.9 218.9 0
ssr 367.4 367.4 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@olamothe olamothe marked this pull request as draft July 8, 2024 15:18
@olamothe olamothe changed the title test(atomic): fix searchbox tests test(atomic): fix commerce tests Jul 8, 2024
@olamothe olamothe marked this pull request as ready for review July 8, 2024 19:26
@olamothe olamothe added this pull request to the merge queue Jul 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 9, 2024
@olamothe olamothe added this pull request to the merge queue Jul 9, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jul 9, 2024
@olamothe
test(atomic): fix commerce tests (#4160)
25bbc08 
KIT-3369
Merged via the queue into master with commit 7d9a5e9 Jul 9, 2024
87 checks passed
@olamothe olamothe deleted the KIT--3369 branch July 9, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexprudhomme alexprudhomme alexprudhomme approved these changes

@fpbrault fpbrault fpbrault approved these changes

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/search

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olamothe @fpbrault @alexprudhomme