-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(answer): error handling #4146
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmgauthier
commented
Jul 4, 2024
dmgauthier
commented
Jul 4, 2024
dmgauthier
commented
Jul 4, 2024
dmgauthier
requested review from
fpbrault,
fbeaudoincoveo,
alexprudhomme and
pathiery
and removed request for
a team
July 4, 2024 13:51
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support product-recommendation : missing SSR support product-listing : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
dmgauthier
force-pushed
the
feat-svcc-3827-answer-api-error-handling
branch
from
July 4, 2024 16:29
f3d689b
to
c2a4ec9
Compare
alexprudhomme
approved these changes
Jul 5, 2024
packages/headless/src/features/generated-answer/generated-answer-selectors.ts
Show resolved
Hide resolved
fpbrault
approved these changes
Jul 5, 2024
pathiery
approved these changes
Jul 5, 2024
fbeaudoincoveo
approved these changes
Jul 5, 2024
dmgauthier
force-pushed
the
feat-SVCC-3827-answerapi-headless-controller-preparation
branch
from
July 8, 2024 13:32
8847e7b
to
06d09e4
Compare
dmgauthier
force-pushed
the
feat-svcc-3827-answer-api-error-handling
branch
from
July 8, 2024 16:46
c2a4ec9
to
6a1a472
Compare
dmgauthier
force-pushed
the
feat-SVCC-3827-answerapi-headless-controller-preparation
branch
from
July 8, 2024 16:48
06d09e4
to
d863c97
Compare
dmgauthier
commented
Jul 8, 2024
dmgauthier
force-pushed
the
feat-svcc-3827-answer-api-error-handling
branch
from
July 8, 2024 16:59
6a1a472
to
dc6edc9
Compare
dmgauthier
force-pushed
the
feat-SVCC-3827-answerapi-headless-controller-preparation
branch
from
July 8, 2024 17:35
d863c97
to
34143ba
Compare
dmgauthier
force-pushed
the
feat-SVCC-3827-answerapi-headless-controller-preparation
branch
from
July 9, 2024 14:41
c4685cc
to
953948d
Compare
dmgauthier
requested review from
erocheleau,
SimonMilord and
mmitiche
and removed request for
a team
July 9, 2024 14:41
dmgauthier
force-pushed
the
feat-svcc-3827-answer-api-error-handling
branch
from
July 9, 2024 14:57
31aff41
to
040ebd3
Compare
dmgauthier
force-pushed
the
feat-SVCC-3827-answerapi-headless-controller-preparation
branch
3 times, most recently
from
July 9, 2024 18:49
4fee423
to
bf21cf8
Compare
dmgauthier
force-pushed
the
feat-svcc-3827-answer-api-error-handling
branch
from
July 9, 2024 18:55
040ebd3
to
82fb824
Compare
Base automatically changed from
feat-SVCC-3827-answerapi-headless-controller-preparation
to
master
July 9, 2024 19:36
dmgauthier
force-pushed
the
feat-svcc-3827-answer-api-error-handling
branch
from
July 9, 2024 19:43
82fb824
to
9a6b3c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates to the Answer Api client to make sure the error handling is proper. Some little extras needed for it to work proper that will make the subsequent review a bit easier.
Why
The Answer Api is almost just a proxy for the stream coming from reveal. And for some technical reasons, the call to the answer api will return an error message but will not return downright error status codes like 400s when the stream fails.
That said, we can rely on the stream end message in case the stream is not working properly, and since its better to give the user or the devs all the information we can, this increment makes sure that the error will appear in the logs and in the state in case we want to leverage the error message in the front end component.
SVCC-3827