feat(atomic-commerce): products-per-page #4107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support product-recommendation : missing SSR support product-listing : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
y-lakhdar
requested changes
Jun 20, 2024
There was a problem hiding this comment.
Something is wrong with the URL management.
Whenever the search page loads with the #perPage= attribute in the URL, 2 search queries are triggered.
The second being the value in the perPage value from the URL
However, when first loading a listing page, the perPage value does not have any effect on the component.
|
also Jira number? |
y-lakhdar
reviewed
Jun 20, 2024
...ents/commerce/atomic-commerce-products-per-page/e2e/atomic-commerce-products-per-page.e2e.ts
Outdated
Show resolved
Hide resolved
y-lakhdar
reviewed
Jun 20, 2024
...ents/commerce/atomic-commerce-products-per-page/e2e/atomic-commerce-products-per-page.e2e.ts
Outdated
Show resolved
Hide resolved
olamothe
previously requested changes
Jun 25, 2024
.../components/commerce/atomic-commerce-products-per-page/atomic-commerce-products-per-page.tsx
Outdated
Show resolved
Hide resolved
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
alexprudhomme
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
alexprudhomme
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
alexprudhomme
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
alexprudhomme
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
alexprudhomme
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
alexprudhomme
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
fbeaudoincoveo
approved these changes
Jul 25, 2024
.../components/commerce/atomic-commerce-products-per-page/atomic-commerce-products-per-page.tsx
Outdated
Show resolved
Hide resolved
.../components/commerce/atomic-commerce-products-per-page/atomic-commerce-products-per-page.tsx
Outdated
Show resolved
Hide resolved
...ents/commerce/atomic-commerce-products-per-page/e2e/atomic-commerce-products-per-page.e2e.ts
Show resolved
Hide resolved
y-lakhdar
approved these changes
Jul 25, 2024
…ts-per-page/atomic-commerce-products-per-page.tsx Co-authored-by: Frederic Beaudoin <[email protected]>
…ts-per-page/atomic-commerce-products-per-page.tsx Co-authored-by: Frederic Beaudoin <[email protected]>
alexprudhomme
force-pushed
the
feat/atomic-commerce-products-per-page
branch
from
0ce4eb6
to
1d9b64a
Compare
alexprudhomme
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
alexprudhomme
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
alexprudhomme
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PageGuardto be "generic" (results->items)PageGuardforatomic-per-pagehttps://coveord.atlassian.net/browse/KIT-3407