Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move more release logic to gha #3676

Merged
merged 6 commits into from
Mar 8, 2024
Merged

chore: move more release logic to gha #3676

merged 6 commits into from
Mar 8, 2024

Conversation

louis-bompart
Copy link
Collaborator

@louis-bompart louis-bompart commented Mar 7, 2024

  • Trigger Deployment Pipeline from GitHub Actions
  • Move "prod stage" into GitHub Actions, under an enviro that requires a rubberstamp
    • Soon, the rubberstamp will be done automatically when the remains of the TeamJenkins phase runs.
    • Eventually, something something ootb from the dep pipeline
    • For now, manual rubberstamp.

Rationale: Jenkins is a PITA, running stuff in GHA should help.

What's going on:

sequenceDiagram
   box blue Public network
   participant SFDC
   participant NPM
   participant GitHub-public
   end
   box purple VPC network
   participant GitHub-coveo
   participant DepPipeline
   participant AWS
   participant TeamJenkins
   end
   GitHub-public->>+NPM: Publish package on beta tag
   GitHub-public->>+SFDC: Publish package
   GitHub-public->>+GitHub-coveo: Continue GitHub workflow on Coveo Hosted Runner
   GitHub-coveo-)DepPipeline: Trigger Deployment Pipeline
   GitHub-coveo->>+GitHub-public: Continue GitHub workflow on GitHub Hosted runner
   activate GitHub-public
   DepPipeline->>DepPipeline: Do the usual checks
   DepPipeline->>+AWS: Deploy files to S3
   DepPipeline->>+TeamJenkins: Dispatch Jenkins Job
   DepPipeline->>+AWS: Invalidate CloudFront Cache
   Note right of GitHub-public: Wait for ✅ 
   deactivate GitHub-public
   TeamJenkins->>+GitHub-public: Approve Production GitHub Environment usage
   GitHub-public->>+NPM: Promote package to latest
   GitHub-public->>+SFDC: Promote package to latest
Loading

https://coveord.atlassian.net/browse/KIT-3025

Copy link

github-actions bot commented Mar 7, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 224.6 224.6 0
commerce 335.6 335.6 0
search 406.4 406.4 0
insight 342.9 342.9 0
product-listing 340.7 340.7 0
product-recommendation 191.9 191.9 0
recommendation 239 239 0
ssr 377.7 377.7 0

Copy link
Member

@olamothe olamothe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly question from me, I wanna make sure I understand the process correctly.

Also, there is a release-process.md documentation, which maybe we could buff up a bit to go a bit more into details how it all works on a technical level ?

.prettierignore Show resolved Hide resolved
JenkinsfileProductionRelease Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
JenkinsfileProductionRelease Show resolved Hide resolved
scripts/deploy/approve-production-release.mjs Show resolved Hide resolved
Copy link
Collaborator Author

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add diagram in release-process.md

@louis-bompart louis-bompart added this pull request to the merge queue Mar 8, 2024
Merged via the queue into master with commit 2e3dba2 Mar 8, 2024
85 checks passed
@louis-bompart louis-bompart deleted the less-jenkins branch March 8, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants