Skip to content

Commit

Permalink
docs(atomic): remove internal flag for atomic-commerce-facet (#4163)
Browse files Browse the repository at this point in the history
This was reported in our internal slack channel about support for
atomic-commerce with PS.
They need access to these properties to power an advance customization

https://coveord.atlassian.net/browse/KIT-3373

---------

Co-authored-by: GitHub Actions Bot <>
  • Loading branch information
olamothe authored Jul 9, 2024
1 parent 71d81ba commit aa001e4
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 20 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -139,13 +139,14 @@ export declare interface AtomicColorFacet extends Components.AtomicColorFacet {}


@ProxyCmp({
inputs: ['facet', 'field', 'isCollapsed', 'summary']
})
@Component({
selector: 'atomic-commerce-category-facet',
changeDetection: ChangeDetectionStrategy.OnPush,
template: '<ng-content></ng-content>',
// eslint-disable-next-line @angular-eslint/no-inputs-metadata-property
inputs: [],
inputs: ['facet', 'field', 'isCollapsed', 'summary'],
})
export class AtomicCommerceCategoryFacet {
protected el: HTMLElement;
Expand All @@ -160,13 +161,14 @@ export declare interface AtomicCommerceCategoryFacet extends Components.AtomicCo


@ProxyCmp({
inputs: ['facet', 'field', 'isCollapsed', 'summary']
})
@Component({
selector: 'atomic-commerce-facet',
changeDetection: ChangeDetectionStrategy.OnPush,
template: '<ng-content></ng-content>',
// eslint-disable-next-line @angular-eslint/no-inputs-metadata-property
inputs: [],
inputs: ['facet', 'field', 'isCollapsed', 'summary'],
})
export class AtomicCommerceFacet {
protected el: HTMLElement;
Expand Down
2 changes: 0 additions & 2 deletions packages/atomic/src/components.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,6 @@ export namespace Components {
interface AtomicCommerceFacet {
/**
* The facet controller instance.
* @
*/
"facet": RegularFacet;
/**
Expand Down Expand Up @@ -5813,7 +5812,6 @@ declare namespace LocalJSX {
interface AtomicCommerceFacet {
/**
* The facet controller instance.
* @
*/
"facet": RegularFacet;
/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -94,26 +94,18 @@ export class AtomicCategoryFacet implements InitializableComponent<Bindings> {

/**
* The summary controller instance.
*
* @internal
*/
@Prop() summary!: Summary<SearchSummaryState | ProductListingSummaryState>;
/**
* The category facet controller instance.
*
* @internal
*/
@Prop() public facet!: CategoryFacet;
/**
* Specifies whether the facet is collapsed.
*
* @internal
*/
@Prop({reflect: true, mutable: true}) public isCollapsed = false;
/**
* The field identifier for this facet.
*
* @internal
*/
@Prop({reflect: true}) field?: string;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -96,26 +96,18 @@ export class AtomicCommerceFacet implements InitializableComponent<Bindings> {

/**
* The Summary controller instance.
*
* @internal
*/
@Prop() summary!: Summary<SearchSummaryState | ProductListingSummaryState>;
/**
* The facet controller instance.
*
* @@internal
*/
@Prop() public facet!: RegularFacet;
/**
* Specifies whether the facet is collapsed.
*
* @internal
*/
@Prop({reflect: true, mutable: true}) public isCollapsed = false;
/**
* The field identifier for this facet.
*
* @internal
*/
@Prop({reflect: true}) field?: string;

Expand Down

0 comments on commit aa001e4

Please sign in to comment.