JSUI-3402 Added explicit isFieldValueCompatible to all facets (#1879)

https://coveord.atlassian.net/browse/JSUI-3402
coveo · May 24, 2022 · d015971 · d015971
1 parent 9dee6fb
commit d015971
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 31 deletions.
diff --git a/src/ui/CategoryFacet/CategoryFacet.ts b/src/ui/CategoryFacet/CategoryFacet.ts
@@ -331,6 +331,7 @@ export class CategoryFacet extends Component implements IAutoLayoutAdjustableIns
   public activeCategoryValue: CategoryValue | undefined;
   public positionInQuery: number;
   public dependsOnManager: DependsOnManager;
+  public isFieldValueCompatible = false;
   public static MAXIMUM_NUMBER_OF_VALUES_BEFORE_TRUNCATING = 15;
   public static NUMBER_OF_VALUES_TO_KEEP_AFTER_TRUNCATING = 10;
 

diff --git a/src/ui/DynamicHierarchicalFacet/DynamicHierarchicalFacet.ts b/src/ui/DynamicHierarchicalFacet/DynamicHierarchicalFacet.ts
@@ -327,6 +327,7 @@ export class DynamicHierarchicalFacet extends Component implements IDynamicHiera
   public position: number;
   public dynamicFacetManager: DynamicFacetManager;
   public isDynamicFacet = true;
+  public isFieldValueCompatible = false;
 
   constructor(public element: HTMLElement, options: IDynamicHierarchicalFacetOptions, bindings?: IComponentBindings) {
     super(element, 'DynamicHierarchicalFacet', bindings);

diff --git a/src/ui/FacetSlider/FacetSlider.ts b/src/ui/FacetSlider/FacetSlider.ts
@@ -347,6 +347,7 @@ export class FacetSlider extends Component {
   public facetHeader: FacetHeader;
   public onResize: EventListener;
   public isSimpleSliderConfig = false;
+  public isFieldValueCompatible = false;
 
   private rangeQueryStateAttribute: string;
   private isEmpty = false;

diff --git a/src/ui/HierarchicalFacet/HierarchicalFacet.ts b/src/ui/HierarchicalFacet/HierarchicalFacet.ts
@@ -176,6 +176,7 @@ export class HierarchicalFacet extends Facet implements IComponentBindings {
   public facetQueryController: HierarchicalFacetQueryController;
   public topLevelHierarchy: IValueHierarchy[];
   public shouldReshuffleFacetValuesClientSide = false;
+  public isFieldValueCompatible = false;
 
   private valueHierarchy: { [facetValue: string]: IValueHierarchy };
   private originalNumberOfValuesToShow: number;

diff --git a/src/ui/TimespanFacet/TimespanFacet.ts b/src/ui/TimespanFacet/TimespanFacet.ts
@@ -76,56 +76,36 @@ export class TimespanFacet extends Component {
     });
   };
 
+  public isFieldValueCompatible = false;
+
   private rangeValues: IRangeValue[] = [
     {
       start: moment(0).toDate(),
-      end: moment()
-        .endOf('day')
-        .toDate(),
+      end: moment().endOf('day').toDate(),
       label: l('AllDates'),
       endInclusive: false
     },
     {
-      start: moment()
-        .startOf('day')
-        .subtract(1, 'day')
-        .toDate(),
-      end: moment()
-        .endOf('day')
-        .toDate(),
+      start: moment().startOf('day').subtract(1, 'day').toDate(),
+      end: moment().endOf('day').toDate(),
       label: l('WithinLastDay'),
       endInclusive: false
     },
     {
-      start: moment()
-        .startOf('day')
-        .subtract(1, 'week')
-        .toDate(),
-      end: moment()
-        .endOf('day')
-        .toDate(),
+      start: moment().startOf('day').subtract(1, 'week').toDate(),
+      end: moment().endOf('day').toDate(),
       label: l('WithinLastWeek'),
       endInclusive: false
     },
     {
-      start: moment()
-        .startOf('day')
-        .subtract(1, 'month')
-        .toDate(),
-      end: moment()
-        .endOf('day')
-        .toDate(),
+      start: moment().startOf('day').subtract(1, 'month').toDate(),
+      end: moment().endOf('day').toDate(),
       label: l('WithinLastMonth'),
       endInclusive: false
     },
     {
-      start: moment()
-        .startOf('day')
-        .subtract(1, 'year')
-        .toDate(),
-      end: moment()
-        .endOf('day')
-        .toDate(),
+      start: moment().startOf('day').subtract(1, 'year').toDate(),
+      end: moment().endOf('day').toDate(),
       label: l('WithinLastYear'),
       endInclusive: false
     }