Skip to content

Commit

Permalink
fix existing non-passing tests
Browse files Browse the repository at this point in the history
  • Loading branch information
bpinsard committed Aug 23, 2024
1 parent 25ec63e commit 46b09d5
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions datalad/distribution/tests/test_install.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,6 @@
)
from datalad.support.gitrepo import GitRepo
from datalad.support.network import get_local_file_url
from datalad.tests.utils_testdatasets import (
_make_dataset_hierarchy,
_mk_submodule_annex,
)
from datalad.tests.utils_pytest import (
DEFAULT_BRANCH,
DEFAULT_REMOTE,
Expand Down Expand Up @@ -75,6 +71,10 @@
with_tempfile,
with_tree,
)
from datalad.tests.utils_testdatasets import (
_make_dataset_hierarchy,
_mk_submodule_annex,
)
from datalad.utils import (
Path,
_path_,
Expand Down Expand Up @@ -140,7 +140,7 @@ def test_invalid_args(path=None):
# or obscure form for multiple installation "things"
assert_raises(IncompleteResultsError, install, ['/higherup.', 'Zoidberg'], dataset=ds)
# and if just given without keyword arg for source -- standard Python exception
assert_raises(TypeError, install, '/higherup.', 'Zoidberg', dataset=ds)
assert_raises(IncompleteResultsError, install, '/higherup.', 'Zoidberg', dataset=ds)


# This test caused a mysterious segvault in gh-1350. I reimplementation of
Expand Down Expand Up @@ -1063,7 +1063,7 @@ def test_install_recursive_github(path=None):
@with_tempfile(mkdir=True)
def test_install_withcfg(src_path=None, dest=None):
src = create(src_path)
ds = install(dest, src_path, cfg_proc=['yoda'])
ds = install(path=dest, source=src_path, cfg_proc=['yoda'])

assert (ds.pathobj / 'README.md').exists()

Expand All @@ -1072,7 +1072,7 @@ def test_install_withcfg(src_path=None, dest=None):
def test_recursive_install_withcfg(src_path=None, dest=None):
src = create(src_path)
src.create('subds')
ds = install(dest, src_path, recursive=True, cfg_proc=['yoda'])
ds = install(path=dest, source=src_path, recursive=True, cfg_proc=['yoda'])

assert (ds.pathobj / 'README.md').exists()
assert (ds.pathobj / 'subds' / 'README.md').exists()

0 comments on commit 46b09d5

Please sign in to comment.