Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating dxpy3 to dxpy #111

Merged
merged 3 commits into from
Jun 13, 2019
Merged

Conversation

anujkumar93
Copy link
Collaborator

@jtratner CC @pkaleta

Since DNAnexus has integrated dxpy3 into dxpy, makes sense to get rid of dxpy3 from stor.

Passed unit and integration tests.

Copy link
Contributor

@pkaleta pkaleta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is there anything remaining to do here before we merge?

@anujkumar93 anujkumar93 self-assigned this Jun 13, 2019
@anujkumar93
Copy link
Collaborator Author

anujkumar93 commented Jun 13, 2019

I had included the release notes along with other small PRs in this single PR: #114 . But since the other ones still need reviewing, adding the release notes separately here. I think this is good to merge now

@anujkumar93 anujkumar93 merged commit 3e77f78 into counsyl:master Jun 13, 2019
@anujkumar93 anujkumar93 deleted the update_dxpy3_to_dxpy branch June 13, 2019 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants