Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LLMProvider Class #77

Merged
merged 22 commits into from
Jul 25, 2024
Merged

LLMProvider Class #77

merged 22 commits into from
Jul 25, 2024

Conversation

Alexander-Baker-24
Copy link
Contributor

Creates support for OpenAI, Gemini, and Bedrock models.

borrrden
borrrden requested changes Jul 17, 2024
View reviewed changes
cblite/EnrichCommand.cc Outdated Show resolved Hide resolved
cblite/llm/Bedrock.hh Show resolved Hide resolved
cblite/llm/Gemini.cc Outdated Show resolved Hide resolved
cblite/llm/Model.hh Outdated Show resolved Hide resolved
cblite/llm/Model.cc Outdated Show resolved Hide resolved
cblite/EnrichCommand.cc Outdated Show resolved Hide resolved
cblite/llm/Bedrock.cc Outdated Show resolved Hide resolved
cblite/EnrichCommand.cc Show resolved Hide resolved
@Alexander-Baker-24 Alexander-Baker-24 changed the title Model Class LLMProvider Class Jul 18, 2024
borrrden
borrrden requested changes Jul 18, 2024
View reviewed changes
cblite/EnrichCommand.cc Outdated Show resolved Hide resolved
cblite/EnrichCommand.cc Outdated Show resolved Hide resolved
cblite/llm/Bedrock.cc Outdated Show resolved Hide resolved
cblite/llm/LLMProvider.cc Outdated Show resolved Hide resolved
cblite/llm/OpenAI.cc Show resolved Hide resolved
borrrden
borrrden requested changes Jul 19, 2024
View reviewed changes
Copy link
Member

@borrrden borrrden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also get rid of "instance" inside of LLMProvider. In general try to find things that have become unused and delete them.

cblite/llm/OpenAI.cc Outdated Show resolved Hide resolved
cblite/llm/LLMProvider.hh Outdated Show resolved Hide resolved
cblite/llm/LLMProvider.cc Outdated Show resolved Hide resolved
borrrden
borrrden requested changes Jul 19, 2024
View reviewed changes
cblite/llm/Gemini.cc Outdated Show resolved Hide resolved
cblite/llm/Gemini.cc Outdated Show resolved Hide resolved
cblite/llm/LLMProvider.cc Outdated Show resolved Hide resolved
@borrrden borrrden self-requested a review July 24, 2024 02:29
borrrden
borrrden requested changes Jul 24, 2024
View reviewed changes
cblite/llm/Gemini.cc Outdated Show resolved Hide resolved
cblite/llm/LLMProvider.cc Show resolved Hide resolved
cblite/llm/LLMProvider.cc Outdated Show resolved Hide resolved
cblite/llm/LLMProvider.hh Outdated Show resolved Hide resolved
cblite/llm/LLMProvider.hh Outdated Show resolved Hide resolved
cblite/llm/LLMProvider.cc Outdated Show resolved Hide resolved
borrrden
borrrden reviewed Jul 24, 2024
View reviewed changes
cblite/EnrichCommand.cc Outdated Show resolved Hide resolved
@borrrden borrrden merged commit 8723ed6 into master Jul 25, 2024
6 checks passed
@borrrden borrrden deleted the Model_Class branch July 25, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borrrden borrrden borrrden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alexander-Baker-24 @borrrden