Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enrich Command #75

Merged
merged 6 commits into from
Jul 16, 2024
Merged

Enrich Command #75

merged 6 commits into from
Jul 16, 2024

Conversation

Alexander-Baker-24
Copy link
Contributor

@Alexander-Baker-24 Alexander-Baker-24 commented Jul 11, 2024

Finished writing the enrich command and updated mkindex to commit 68d90b4.

@borrrden borrrden self-requested a review July 11, 2024 00:49
Copy link
Member

@borrrden borrrden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR also only mentions the enrich command, with no mention of the modifications to the mkindex command.

Xcode/.DS_Store Outdated Show resolved Hide resolved
cblite/.DS_Store Outdated Show resolved Hide resolved
cblite/EnrichCommand.cc Outdated Show resolved Hide resolved
cblite/EnrichCommand.cc Outdated Show resolved Hide resolved
cblite/EnrichCommand.hh Outdated Show resolved Hide resolved
tests/TokenizerTest.cc Outdated Show resolved Hide resolved
vendor/couchbase-lite-core-EE Outdated Show resolved Hide resolved
@Alexander-Baker-24 Alexander-Baker-24 force-pushed the Enrich_Command branch 2 times, most recently from 2c4ff87 to b971ddd Compare July 11, 2024 21:37
* Finished writing enrich command
* Cleaned up enrich command according to comments.
* Fixed CMakeList.txt
cblite/EnrichCommand.cc Outdated Show resolved Hide resolved
tests/TokenizerTest.cc Outdated Show resolved Hide resolved
cblite/EnrichCommand.hh Outdated Show resolved Hide resolved
cblite/EnrichCommand.cc Outdated Show resolved Hide resolved
Tool.hh Outdated Show resolved Hide resolved
Copy link
Member

@borrrden borrrden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one last little thing I found

processFlags({
{"--offset", [&]{offsetFlag();}},
{"--limit", [&]{limitFlag();}},
//{"--writeable", [&]{writeableFlag();}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this comment is not needed then remove it

@borrrden borrrden merged commit fa63e1d into master Jul 16, 2024
3 of 6 checks passed
@borrrden borrrden deleted the Enrich_Command branch July 16, 2024 21:52
borrrden pushed a commit that referenced this pull request Jul 16, 2024
A command that is able to produce LLM embeddings in a couchbase lite database.  Also update mkindex to be able to create a vector index.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants