Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBG-4403: update rev cache size api docs for size stat #7257

Merged
merged 2 commits into from
Jan 3, 2025
Merged

CBG-4403: update rev cache size api docs for size stat #7257

merged 2 commits into from
Jan 3, 2025

Conversation

gregns1
Copy link
Contributor

@gregns1 gregns1 commented Jan 3, 2025

CBG-4403

  • We recently added a size stat for rev cache, we need to add a disclaimer to rev cache sizing on api docs to show that that the defined size in the api could be exceeded by 10%.

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Integration Tests

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025 •
edited
Loading

Redocly previews

@torcolvin torcolvin merged commit 94e223e into main Jan 3, 2025
43 checks passed
@torcolvin torcolvin deleted the CBG-4403 branch January 3, 2025 15:14
gregns1 added a commit that referenced this pull request Jan 6, 2025
@gregns1
CBG-4403: update rev cache size api docs for size stat (#7257)
4187e63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torcolvin torcolvin torcolvin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregns1 @torcolvin