Skip to content

Commit

Permalink
fix failing test + mistake in docs
Browse files Browse the repository at this point in the history
Signed-off-by: Gregory Newman-Smith <[email protected]>
  • Loading branch information
gregns1 committed Sep 4, 2024
1 parent 69b3190 commit 1fd6027
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 2 additions & 1 deletion docs/api/components/schemas.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1304,10 +1304,11 @@ Database:
description: The maximum number of revisions that can be stored in the revision cache.
type: string
default: 5000
max_item_count:
max_memory_count_mb:
description: |-
The maximum amount of memory the revision cache should take up in MB, setting to 0 will disable any eviction based on memory at rev cache.
When set this memory limit will work in in hand with revision cache size parameter. So you will potentially get eviction at revision cache both based off memory footprint and number of items in the cache.
**This is an enterprise-edition feature only**
type: integer
default: 0
shard_count:
Expand Down
2 changes: 2 additions & 0 deletions rest/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3095,6 +3095,8 @@ func TestRevCacheMemoryLimitConfig(t *testing.T) {
resp = rt.SendAdminRequest(http.MethodGet, "/db1/_config", "")
RequireStatus(t, resp, http.StatusOK)

// empty db config struct
dbConfig = DbConfig{}
require.NoError(t, json.Unmarshal(resp.BodyBytes(), &dbConfig))
assert.NotNil(t, dbConfig.CacheConfig)

Expand Down

0 comments on commit 1fd6027

Please sign in to comment.