chore: use context.Context and appmodule.Environment in 08-wasm #7880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
technicallyty
requested review from
AdityaSripal,
gjermundgaraba and
srdtrk
as code owners
10 tasks
|
|
|
||
| sdk "github.com/cosmos/cosmos-sdk/types" | ||
|
|
||
| "github.com/cosmos/ibc-go/modules/light-clients/08-wasm/types" | ||
| ) | ||
|
|
||
| // emitStoreWasmCodeEvent emits a store wasm code event | ||
| func emitStoreWasmCodeEvent(ctx sdk.Context, checksum types.Checksum) { |
There was a problem hiding this comment.
For this, we have done another approach in transfer which I think is a little better: make the function a receiver function on the keeper and just pass in the context:
func (k Keeper) EmitTransferEvent(ctx context.Context
|
|
||
| func moduleLogger(ctx sdk.Context) log.Logger { | ||
| return ctx.Logger().With("module", "x/"+exported.ModuleName+"-"+types.ModuleName) | ||
| func (k Keeper) Logger(_ context.Context) log.Logger { |
There was a problem hiding this comment.
Is the context still there due to some interface that needs to be satisifed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
stacked PR of #7866
supercedes: #7836
Closes: #7712
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.