refactor: use address.Codec to replace deprecated function #7802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ch0
requested review from
AdityaSripal,
gjermundgaraba and
srdtrk
as code owners
|
Hi @1ch0, after considering this for a bit more, we've decided that this should be done as a larger body of work, rather than have many small PRs to clean this up. Therefore I've created an issue for this: #7835 If you want to take on this work, let me know, but for the time being I will close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the deprecated address-related functions with the new address.Codec implementations:
Replace sdk.AccAddressFromBech32() with address.Codec StringToBytes()
Replace sdk.AccAddress.String() with address.Codec BytesToString()`
These changes align with the latest SDK address handling practices and remove usage of deprecated functions.