Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unecessary SDKGasMeter impl #23503

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

technicallyty
Copy link
Contributor

@technicallyty technicallyty commented Jan 24, 2025

Description

Closes: n/a

this type is not used anywhere and cannot be used anywhere since there is no constructor and the field it has is private.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • Refactor

    • Removed SDKGasMeter struct and its associated methods from the runtime gas management system.
  • Impact

    • Changes to gas tracking and consumption mechanisms in the core runtime environment.

@technicallyty technicallyty requested review from julienrbrt and a team as code owners January 24, 2025 21:41
Copy link
Contributor

coderabbitai bot commented Jan 24, 2025

📝 Walkthrough

Walkthrough

The pull request involves the removal of the SDKGasMeter struct and its associated methods from the runtime/gas.go file. This change significantly alters the gas management approach in the runtime, eliminating a wrapper around the SDK's GasMeter interface. The removal suggests a potential restructuring of gas consumption tracking and management, with the GasService and CoreGasmeter likely becoming the primary mechanisms for handling gas-related operations.

Changes

File Change Summary
runtime/gas.go - Removed SDKGasMeter struct
- Deleted methods: GasConsumed(), GasConsumedToLimit(), GasRemaining(), Limit(), ConsumeGas(), RefundGas(), IsPastLimit(), IsOutOfGas(), String()

Suggested Reviewers


📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2675857 and dc8b42f.

📒 Files selected for processing (1)
  • runtime/gas.go (0 hunks)
💤 Files with no reviewable changes (1)
  • runtime/gas.go
⏰ Context from checks skipped due to timeout of 90000ms (9)
  • GitHub Check: test-hubl
  • GitHub Check: test-cosmovisor
  • GitHub Check: test-errors
  • GitHub Check: test-depinject
  • GitHub Check: build (arm64)
  • GitHub Check: build (amd64)
  • GitHub Check: golangci-lint
  • GitHub Check: dependency-review
  • GitHub Check: Summary

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@technicallyty technicallyty added the backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release label Jan 24, 2025
@technicallyty technicallyty requested a review from aljo242 January 24, 2025 21:42
@julienrbrt julienrbrt added this pull request to the merge queue Jan 24, 2025
Merged via the queue into main with commit e9b16a4 Jan 24, 2025
78 of 79 checks passed
@julienrbrt julienrbrt deleted the technicallyty/remove-unecessary-meter-impl branch January 24, 2025 22:55
mergify bot pushed a commit that referenced this pull request Jan 24, 2025
julienrbrt pushed a commit that referenced this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants