Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix changelog for v0.52.0-rc.2 #23502

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: fix changelog for v0.52.0-rc.2 #23502

wants to merge 1 commit into from
+8 −1

Conversation

aljo242
Copy link
Collaborator

@aljo242 aljo242 commented Jan 24, 2025 •
edited by coderabbitai bot
Loading

Set's the changelog to be up to date with what was done in the release branch

Summary by CodeRabbit

Release Notes for Cosmos SDK v0.52.0-rc.2

  • Improvements

    • Removed legacy v2 code from the codebase
    • Deprecated Block field in GetBlockByHeightResponse

  • Bug Fixes

    • Added missing timeoutTimestamp in transaction builder

  • Release Details

    • Updated release date to 2025-01-23

@aljo242 aljo242 requested a review from a team as a code owner January 24, 2025 19:31
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 24, 2025 •
edited
Loading

📝 Walkthrough

Walkthrough

The pull request updates the CHANGELOG.md for Cosmos SDK version v0.52.0-rc.2. The primary modifications include updating the release date from January 17th to January 23rd, 2025, and adding several changelog entries. These entries cover improvements such as removing v2 code, deprecating certain response fields, and adding missing transaction parameters. The changelog maintains its structured format with sections for features, improvements, and bug fixes.

Changes

File Change Summary
CHANGELOG.md - Updated release date for v0.52.0-rc.2 from 2025-01-17 to 2025-01-23
- Added entries for code removal, field deprecation, and transaction parameter addition

Possibly related PRs

Suggested labels

backport/v0.52.x

Suggested reviewers

  • julienrbrt
  • tac0turtle
  • alpe

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jan 24, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
CHANGELOG.md (1)

87-89: Fix unordered list indentation

The unordered list items under the guidelines section should be indented with 4 spaces instead of 2 spaces to maintain consistent formatting throughout the document.

-  * Don't flag issues or omissions in the AI-generated summaries.
-  * Don't verify the impact of locally-scoped changes on the entire codebase...
-  * Don't flag unused imports and variables...
+    * Don't flag issues or omissions in the AI-generated summaries.
+    * Don't verify the impact of locally-scoped changes on the entire codebase...
+    * Don't flag unused imports and variables...
🧰 Tools
🪛 Markdownlint (0.37.0)

87-87: Expected: 4; Actual: 2
Unordered list indentation

(MD007, ul-indent)

88-88: Expected: 4; Actual: 2
Unordered list indentation

(MD007, ul-indent)

89-89: Expected: 4; Actual: 2
Unordered list indentation

(MD007, ul-indent)

📜 Review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2675857 and 8c3a7b3.

📒 Files selected for processing (1)
  • CHANGELOG.md (2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
CHANGELOG.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

🪛 Markdownlint (0.37.0)
CHANGELOG.md

87-87: Expected: 4; Actual: 2
Unordered list indentation

(MD007, ul-indent)

88-88: Expected: 4; Actual: 2
Unordered list indentation

(MD007, ul-indent)

89-89: Expected: 4; Actual: 2
Unordered list indentation

(MD007, ul-indent)

⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: tests (02)
  • GitHub Check: build (arm64)
  • GitHub Check: build (amd64)
  • GitHub Check: dependency-review
  • GitHub Check: Summary
🔇 Additional comments (1)
CHANGELOG.md (1)

Line range hint 1-1000: LGTM! Well-structured changelog documentation

The changelog is well-organized and follows good practices:

  • Clear version sections with dates
  • Changes categorized by type (Features, Improvements, Bug Fixes, etc.)
  • Detailed descriptions with PR references
  • Breaking changes clearly marked
🧰 Tools
🪛 Markdownlint (0.37.0)

87-87: Expected: 4; Actual: 2
Unordered list indentation

(MD007, ul-indent)

88-88: Expected: 4; Actual: 2
Unordered list indentation

(MD007, ul-indent)

89-89: Expected: 4; Actual: 2
Unordered list indentation

(MD007, ul-indent)

julienrbrt
julienrbrt reviewed Jan 24, 2025
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those newly added changes should be deleted from unreleased above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@julienrbrt julienrbrt julienrbrt left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aljo242 @julienrbrt