-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: export HasRegisterServices
(backport #23488)
#23490
Conversation
(cherry picked from commit 8493d4f) # Conflicts: # CHANGELOG.md # runtime/app.go # testutil/mock/types_module_module.go
Cherry-pick of 8493d4f has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
move
hasServicesV1
toHasRegisterServices
and use where needed.Summary by CodeRabbit
Refactor
hasServicesV1
toHasRegisterServices
CoreAppModuleAdaptor
tonewCoreAppModuleAdaptor
Documentation
The changes primarily focus on modernizing the module service registration process and improving interface clarity in the SDK.
This is an automatic backport of pull request #23488 done by [Mergify](https://mergify.com).