Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(systemtests): to avoid invalid order_by used in TestGetTxEvents_GRPCGateway #23290

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
+22 −11
Draft

fix(systemtests): to avoid invalid order_by used in TestGetTxEvents_GRPCGateway #23290

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7aa1040
fix(systemtests): to avoid invalid order_by used in TestGetTxEvents_G…
mmsqe Jan 10, 2025
5bd1207
align previous
mmsqe Jan 10, 2025
eb1e0c9
Merge remote-tracking branch 'origin/main' into fix_orderby
mmsqe Jan 10, 2025
cba58ac
fix upgrade
mmsqe Jan 10, 2025
f4bcb15
Merge remote-tracking branch 'origin/main' into fix_orderby
mmsqe Jan 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/systemtests/tx_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,19 +363,19 @@ func TestGetTxEvents_GRPCGateway(t *testing.T) {
},
{
"valid request: order by asc",
fmt.Sprintf("%s/cosmos/tx/v1beta1/txs?query=%s&query=%s&order_by=ORDER_BY_ASC", baseURL, bankMsgSendEventAction, "message.module='bank'"),
fmt.Sprintf("%s/cosmos/tx/v1beta1/txs?query=%s&query=%s&order_by=%d", baseURL, bankMsgSendEventAction, "message.module='bank'", tx.OrderBy_ORDER_BY_ASC),
false,
"", 2,
},
{
"valid request: order by desc",
fmt.Sprintf("%s/cosmos/tx/v1beta1/txs?query=%s&query=%s&order_by=ORDER_BY_DESC", baseURL, bankMsgSendEventAction, "message.module='bank'"),
fmt.Sprintf("%s/cosmos/tx/v1beta1/txs?query=%s&query=%s&order_by=%d", baseURL, bankMsgSendEventAction, "message.module='bank'", tx.OrderBy_ORDER_BY_DESC),
false,
"", 2,
},
{
"invalid request: invalid order by",
fmt.Sprintf("%s/cosmos/tx/v1beta1/txs?query=%s&query=%s&order_by=invalid_order", baseURL, bankMsgSendEventAction, "message.module='bank'"),
fmt.Sprintf("%s/cosmos/tx/v1beta1/txs?query=%s&query=%s&order_by=%d", baseURL, bankMsgSendEventAction, "message.module='bank'", 777),
true,
"is not a valid tx.OrderBy", 0,
},
Expand All @@ -401,7 +401,7 @@ func TestGetTxEvents_GRPCGateway(t *testing.T) {
} else {
require.NoError(t, err)
txs := gjson.Get(string(res), "txs").Array()
require.Equal(t, len(txs), tc.expLen)
require.Equal(t, tc.expLen, len(txs))
}
})
}
Expand Down
Loading