feat(store/v2): support rocksdb and pebbledb as RawDB #19607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughWalkthroughThe introduced changes focus on implementing Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
@alexanderbez your pull request is missing a changelog! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 6
Configuration used: .coderabbit.yml
Files selected for processing (6)
- store/db/db_test.go (2 hunks)
- store/db/goleveldb.go (1 hunks)
- store/db/pebbledb.go (1 hunks)
- store/db/rocksdb.go (1 hunks)
- store/go.mod (1 hunks)
- store/go.sum (1 hunks)
Additional comments: 8
store/db/db_test.go (3)
- 19-21: The addition of the
TearDownSuitemethod for closing the database connection after tests is a good practice for resource cleanup.- 100-107: The
TestPebbleDBSuitefunction correctly initializes a PebbleDB instance for testing, using a temporary directory for isolation.- 109-116: The
TestRocksDBSuitefunction correctly initializes a RocksDB instance for testing, using a temporary directory for isolation.store/go.mod (1)
- 13-13: The update of the
github.com/cosmos/iavldependency tov1.1.0is noted. Ensure that this version's changes are compatible with the project's requirements and that all tests pass.store/db/pebbledb.go (1)
- 44-70: The
Close,Get, andHasmethods are correctly implemented and follow best practices for resource management and error handling.store/db/rocksdb.go (1)
- 54-67: The
Close,Get, andHasmethods are correctly implemented and follow best practices for resource management and error handling.store/db/goleveldb.go (1)
- 20-20: Explicitly declaring
GoLevelDBas an implementation ofstore.RawDBis a good practice for clarity and ensures thatGoLevelDBadheres to thestore.RawDBinterface. This change enhances code readability and maintainability.store/go.sum (1)
- 49-50: The update of
github.com/cosmos/iavlfromv1.0.0-beta.1.0.20240125174944-11ba4961dae9tov1.1.0is noted. Ensure that this version bump is compatible with the rest of the project's dependencies and does not introduce breaking changes that could affect the project's stability or functionality.
tac0turtle
requested changes
Mar 3, 2024
tac0turtle
dismissed stale reviews from testinginprod, cool-develope, and themself
dismissing due to changes
There was a problem hiding this comment.
Review Status
Actionable comments generated: 6
Configuration used: .coderabbit.yml
Files selected for processing (4)
- store/db/goleveldb.go (1 hunks)
- store/db/pebbledb.go (1 hunks)
- store/db/rocksdb.go (1 hunks)
- store/db/rocksdb_noflag.go (1 hunks)
Files skipped from review as they are similar to previous changes (3)
- store/db/goleveldb.go
- store/db/pebbledb.go
- store/db/rocksdb.go
Additional comments: 1
store/db/rocksdb_noflag.go (1)
- 1-2: The use of both
//go:build !rocksdband// +build !rocksdbdirectives for conditional compilation is correct and follows best practices. This ensures compatibility with both older and newer versions of Go. However, it's important to note that the// +builddirective is deprecated in favor of//go:buildin Go 1.17 and later. If support for Go versions before 1.17 is not required, consider removing the// +builddirective.
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: .coderabbit.yml
Files selected for processing (4)
- store/db/db.go (1 hunks)
- store/db/goleveldb.go (2 hunks)
- store/db/pebbledb.go (1 hunks)
- store/db/rocksdb.go (1 hunks)
Files skipped from review as they are similar to previous changes (4)
- store/db/db.go
- store/db/goleveldb.go
- store/db/pebbledb.go
- store/db/rocksdb.go
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: .coderabbit.yml
Files selected for processing (5)
- store/db/db_test.go (2 hunks)
- store/db/rocksdb.go (1 hunks)
- store/db/rocksdb_noflag.go (1 hunks)
- store/go.mod (1 hunks)
- store/go.sum (1 hunks)
Files skipped from review as they are similar to previous changes (5)
- store/db/db_test.go
- store/db/rocksdb.go
- store/db/rocksdb_noflag.go
- store/go.mod
- store/go.sum
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: .coderabbit.yml
Files selected for processing (2)
- store/db/rocksdb.go (1 hunks)
- store/db/rocksdb_noflag.go (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- store/db/rocksdb.go
- store/db/rocksdb_noflag.go
sontrinh16
approved these changes
Mar 18, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| func (b *rocksDBBatch) Close() error { | ||
| panic("rocksdb must be built with -tags rocksdb") |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
cool-develope
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #19606
This PR introduces support for PebbleDB and RocksDB as backing implementations of
RawDBwhich is used to perform a migration from store/v1 to store/v2.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Summary by CodeRabbit