Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-decl overhaul (including inline struct fixes) #657
Multi-decl overhaul (including inline struct fixes) #657
Changes from 44 commits
eeab8d1
b7a119a
dcf9da0
4bf6ff9
8184556
c2ea286
17de215
9dc4968
fb819ef
20b23b8
9af2fe9
500d870
52db941
a4c4ad1
843cad0
755f651
faf5006
d3a48d6
8839ad1
6bbf9ca
51e777a
5f69ae8
c91ba7b
ff1ae35
ccdc611
4de64f7
6032aaf
6fb03df
d926bd6
56d7303
3666d95
cd6cccb
e8ad64c
8d1735a
ae9e314
740390e
e6a0d4d
e89ece7
d75748f
77145eb
d3220b2
86b1acc
74685c6
2073f33
13c0d77
0d578bc
e594faa
c9888f2
220234c
0c2b38c
d3de950
f7ae158
f18cc23
d437bad
4c85580
5ed5ad3
eea9b94
36e262a
ab2d1a5
0bbfe7f
a83daa6
bc9f3bc
2a58731
31b82a6
aff9f80
f7ff59f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC
VisitedMultiDeclMembers
in theDeclRewriter
class does approximately this. I don't have a strong opinion on if the information should be tracked there or here, but do you have a reason for adding this field whenVisitedMultiDeclMembers
already existed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VisitedMultiDeclMembers
is removed in this PR. So shall I leaveAlreadyRewritten
here or remove it in favor of aVisitedMultiDecls
analogous to the previousVisitedMultiDeclMembers
?