more sonar

correaa · Jan 28, 2025 · 71f0a60 · 71f0a60
1 parent 3910a54
commit 71f0a60
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.gitlab-ci-correaa.yml b/.gitlab-ci-correaa.yml
@@ -956,9 +956,8 @@ sonar:
     - apt-get -qq update && apt-get -qq install --no-install-recommends -y --quiet ca-certificates cmake curl unzip g++ gcovr make lcov libboost-timer-dev libboost-serialization-dev libblas-dev libfftw3-dev pkg-config wget
     - g++ --version
     - mkdir build
-    # Download sonar-scanner
+    # Download sonar-scanner, from https://docs.sonarsource.com/sonarqube-cloud/advanced-setup/ci-based-analysis/sonarscanner-cli/
     - wget https://binaries.sonarsource.com/Distribution/sonar-scanner-cli/sonar-scanner-cli-6.2.1.4610-linux-x64.zip -O sonar-scanner.zip
-    # - curl -sSLo ./sonar-scanner.zip 'https://binaries.sonarsource.com/Distribution/sonar-scanner-cli/sonar-scanner-cli-5.0.1.3006-linux.zip'
     - unzip -o sonar-scanner.zip
     - mv sonar-scanner-6.2.1.4610-linux-x64 sonar-scanner
     # - Download build-wrapper

diff --git a/include/boost/multi/array.hpp b/include/boost/multi/array.hpp
@@ -1120,7 +1120,8 @@ struct array<T, 0, Alloc> : static_array<T, 0, Alloc> {
 
 template<class T, ::boost::multi::dimensionality_type D, class Alloc>
 struct array : static_array<T, D, Alloc> {
-	~array() = default;
+	// ~array() = default;
+	~array() {}  // sonar is asking for this, deallocation is handled by base class TODO(correaa) make constructors also defaulted to base?
 	using static_ = static_array<T, D, Alloc>;
 	static_assert(
 		std::is_same_v<