feat: mentions #1205
Open
feat: mentions #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 96e1524 Author: JAM\mallo <[email protected]> Date: Sat Apr 29 02:14:24 2023 -0400 fix item entry collapsible commit c4b2ae1 Author: JAM\mallo <[email protected]> Date: Wed Apr 19 22:19:29 2023 -0400 add item "emotes" AND ext tracker commit 07ee272 Author: JAM\mallo <[email protected]> Date: Fri Mar 31 19:50:48 2023 -0400 no message commit d1a8753 Author: JAM\mallo <[email protected]> Date: Fri Mar 31 13:16:00 2023 -0400 no message commit 1793229 Author: JAM\mallo <[email protected]> Date: Fri Mar 31 12:51:44 2023 -0400 no message
…extension/emotes # Conflicts: # .env.example # app/Helpers/Helpers.php # app/Http/Controllers/WorldController.php # config/lorekeeper/admin_sidebar.php # config/lorekeeper/extension_tracker.php # resources/views/world/_sidebar.blade.php # routes/lorekeeper/admin.php
…into feature/mentions
…into feature/mentions
…racter tags, emotes
…into feature/mentions
…into feature/mentions
…into feature/mentions
SpeedyD
suggested changes
Jan 24, 2025
There was a problem hiding this comment.
Looks like this is going to majorly clash with my #1097 PR.. Which, y'know, fair. This looks like a cleaner method, and allows for more.
...But I do not like the fact that it effectively removes a TON of backwards compatibility. Regenerating or simply editing older posts/pages/comments/etc. will break this way, as the parsed text is overwritten with the non-parsed text.. and with the code changed to what it is, it will not re-parse the existing code.
I cannot in good conscious approve this PR as it is.
And.. well, most minor note, I guess, is that the config/lorekeeper/extension_tracker.php file is re-added for some reason.. 🤔
SpeedyD
reviewed
Jan 24, 2025
SpeedyD
approved these changes
Jan 27, 2025
LostInProgres
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
combines emotes extension & @SpeedyD 's extended mentions into an ajax based system for ease of use & backwards compatibility with updates