Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: criteria loot #1191

Merged
merged 3 commits into from
Jan 12, 2025
Merged

fix: criteria loot #1191

merged 3 commits into from
Jan 12, 2025

Conversation

ScuffedNewt
Copy link
Contributor

follow up to #1124 since it has been left open without much activity

@itinerare itinerare added bug Something isn't working needs review Pull requests that are pending community review labels Jan 12, 2025
SpeedyD
SpeedyD approved these changes Jan 12, 2025
View reviewed changes
Copy link
Contributor

@SpeedyD SpeedyD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this means PR 1124 would be closed, as this is the same fix but.. uh.. better.

@itinerare itinerare added reviewed Pull requests that have received community review and are pending merge and removed needs review Pull requests that are pending community review labels Jan 12, 2025
@itinerare itinerare mentioned this pull request Jan 12, 2025
Closed
@itinerare itinerare merged commit bb1d441 into corowne:develop Jan 12, 2025
3 checks passed
@ScuffedNewt ScuffedNewt deleted the fix/criteria-loot branch January 12, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itinerare itinerare itinerare approved these changes

@SpeedyD SpeedyD SpeedyD approved these changes

Assignees
No one assigned
Labels
bug Something isn't working reviewed Pull requests that have received community review and are pending merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ScuffedNewt @SpeedyD @itinerare