Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(currency): Visibility settings #1187

Merged
merged 8 commits into from
Jan 10, 2025

Conversation

SpeedyD
Copy link
Contributor

@SpeedyD SpeedyD commented Jan 10, 2025

Adds option to make a currency invisible, hiding them from the user's profile and bank. Also hides the currency in the encyclopedia, except for permissioned staff.

@itinerare itinerare added enhancement New feature or request needs review Pull requests that are pending community review labels Jan 10, 2025
@SpeedyD SpeedyD marked this pull request as draft January 10, 2025 17:32
@SpeedyD
Copy link
Contributor Author

SpeedyD commented Jan 10, 2025

Getting some confusing errors on one of my sites' locals, so I'm doing another test run 🤔

…Visible

* corowne/develop:
  fix(currencies): populate categories when editing currency
  fix(currencies): remove extraneous values from populateCategoryData
@SpeedyD
Copy link
Contributor Author

SpeedyD commented Jan 10, 2025

Yeah, okay, I have no idea how some of my changes got undone when committing, but this was all that was messed up.

Merged in dev updates and re-opening for review.

@SpeedyD SpeedyD marked this pull request as ready for review January 10, 2025 17:51
@itinerare itinerare added reviewed Pull requests that have received community review and are pending merge and removed needs review Pull requests that are pending community review labels Jan 10, 2025
@itinerare itinerare merged commit 18062a2 into corowne:develop Jan 10, 2025
6 checks passed
@SpeedyD SpeedyD deleted the feat/currency_is_Visible branch January 10, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request reviewed Pull requests that have received community review and are pending merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants