Feat(shop): Merge "Shop Features" into develop

[ScuffedNewt]

Closes #1094

mostly because i need countAssets for another dev feature lol

I don't think this is missing any features, but feel free to correct me if there is anything that should be added and isn't currently a feature, since like I said this extension will probably be fairly immutable once merged

to-do:

• credits need to be added on credits page instead of extension config

some things that should be tested (by people other than me):

• one-time purchases
• different cost options
• coupons on diff stock
• restocking / random stock
• limited_stock_coupon_settings

[SpeedyD]

Anyway @ScuffedNewt, I want to approve this but I'm awaiting your final todo

credits need to be added on credits page instead of extension config

Unless you already did this and I missed it..?

[itinerare]

Looks good-- just put the example .env back and make those credits changes, please!

[ScuffedNewt]

the coupon issues mentioned in dms apply to old logs and are not easily fixable since the logs dd not track the usage of coupons

[SpeedyD]

Glad you put in proper crediting, but you forgot to remove the config/lorekeeper/ext-tracker/shop_features.php file. :)

[ScuffedNewt]

Glad you put in proper crediting, but you forgot to remove the config/lorekeeper/ext-tracker/shop_features.php file. :)

i will make a pr after since this is on the actual extension branch

[SpeedyD]

Glad you put in proper crediting, but you forgot to remove the config/lorekeeper/ext-tracker/shop_features.php file. :)

i will make a pr after since this is on the actual extension branch

I'll hold you to that.

[ScuffedNewt]

please have a proper test on local, have a
production.ERROR: Attempt to read property "id" on null {"userId":N,"exception":"[object] (ErrorException(code: 0): Attempt to read property \"id\" on null at www/app/Models/Shop/ShopLog.php:147
on a site but not sure if this is due to other reasons

[itinerare]

I'll see if I can give it a look (maybe tomorrow?)...