feat(Pages/News): Regenerate Function #1168
Conversation
| * | ||
| * @return \Illuminate\Http\RedirectResponse | ||
| */ | ||
| public function postRegenPage(Request $request, PageService $service, $id) { |
There was a problem hiding this comment.
Nit-pick but i think this would be better to be more descriptive like postRegeneratePageText or something! otherwise looks good
There was a problem hiding this comment.
..It's just a function name. In an attempt to be consistent with other functions, I use a simple get and post combination, to the point.. What it does is explained in the context box right above it..
I don't see a reason to rename the function?
There was a problem hiding this comment.
there's no particular reason aside from stylistic choice, I just think that the extra information in the function name makes sense and follows along some of the others that exist in LK! you don't have to agree or follow that though
There was a problem hiding this comment.
Seems clear enough to me as-is.
itinerare
added
enhancement
itinerare
added
reviewed
Takes the text data and re-parses it! Useful for regenerating mentions without updating post time or user or whatnot. :)