fix(characters): improve fullsize image format handling around design updates #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… updates - use display image format for thumbnails, fullsize format for design update image - set fullsize extension when approving design update - add character image format fix command
itinerare
added
bug
SpeedyD
approved these changes
Dec 27, 2024
ScuffedNewt
approved these changes
Dec 27, 2024
itinerare
added
reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dug down and realized that the issue with incoming fullsize character images not being in the correct file format was largely that design updates weren't handling the distinction very well.
We've been using a version of these fixes successfully for a while now; however this version is, naturally, rendered a little more generic and should be tested regardless to make sure the effects are as intended.
This is also disentangled from changes made on a few branches and coalesced into one change, so it's worth testing on that basis as well.