style: making some rows look nicer #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- User profile rows no longer are so small that they break heading text on >= 992px viewports (as their biggest breakpoint is lg) - Character information pages (image info and stats tab) have also had rows adjusted to prevent breaking headings
SpeedyD
approved these changes
Oct 29, 2024
itinerare
approved these changes
Oct 29, 2024
itinerare
added
the
reviewed
SpeedyD
added a commit
to SpeedyD/lorekeeper
that referenced
this pull request
Oct 30, 2024
…ase-to-dev * corowne/release/v3.0.0: fix(galleries): make some queries more efficient (corowne#1098) fix: improve user profile, character page row styling on smaller viewports/mobile (corowne#1099)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know this was mentioned a few times in the server haha so I've gone ahead and did a quick few style edits...these edits just add
no-guttersto a handful of rows to eliminate some of the preset horizontal padding on child columns and adjusts a few of the column numbers. The following pages received changes:User Profile
Character Information Page (for mobile, tested at 320px)
This, of course, doesn't account for site owners who may use alternative fonts or change the size of headings themselves in the CSS...but in that case you'd want to do further edits yourself regardless, hahaha.