fix(galleries): more efficient queries #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AW0005
changed the title
SpeedyD
approved these changes
Oct 29, 2024
itinerare
reviewed
Oct 29, 2024
| @@ -26,7 +26,7 @@ | |||
| </p> | |||
| @endif | |||
| <p>{!! $gallery->description !!}</p> | |||
| @if (!$gallery->submissions->count() && $gallery->children->count() && $childSubmissions->count()) | |||
| @if (!$gallery->submissions()->count() && $gallery->children->count() && $childSubmissions->count()) | |||
There was a problem hiding this comment.
What's the reasoning here?
There was a problem hiding this comment.
Without the parenthesis it's pulling all submissions into memory to count them instead of letting sql count them
There was a problem hiding this comment.
I thought it was the reverse? Or is there some particular nuance of relation-vs-query I'm missing here
There was a problem hiding this comment.
Nope, not the reverse:
https://laravel.com/docs/10.x/eloquent-relationships#querying-relations
itinerare
approved these changes
Oct 29, 2024
itinerare
added
reviewed
SpeedyD
added a commit
to SpeedyD/lorekeeper
that referenced
this pull request
Oct 30, 2024
…ase-to-dev * corowne/release/v3.0.0: fix(galleries): make some queries more efficient (corowne#1098) fix: improve user profile, character page row styling on smaller viewports/mobile (corowne#1099)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making a couple more gallery related queries more efficient.