Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent throttling on different links #1071

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

ScuffedNewt
Copy link
Contributor

adds a url to the throttle key so users arent limited from preforming different actions
also adds an exemption to admin routes

why?

  • this feature is intended to stop spamming, a blanket limit (especially at 10 seconds) can be inhibiting on a click / request heaving application like lorekeeper
  • admin routes have similar reasoning to the above, and are at lower risk of spamming being an issue

@itinerare itinerare added enhancement New feature or request needs review Pull requests that are pending community review labels Sep 23, 2024
Copy link
Contributor

@SpeedyD SpeedyD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, this is a necessary and welcome change cause I tend to open multiple things in tabs and rapid fire approve when I'm doing approvals... and I think you can guess the problem.

So thanks, Newt!

@itinerare itinerare added reviewed Pull requests that have received community review and are pending merge and removed needs review Pull requests that are pending community review labels Sep 26, 2024
@itinerare itinerare merged commit 2b135f0 into corowne:develop Sep 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request reviewed Pull requests that have received community review and are pending merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants