Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Extra / Nice-To-Have Filters #1064

Merged
merged 4 commits into from
Oct 24, 2024
Merged

Conversation

ScuffedNewt
Copy link
Contributor

Adds some filters around the site!
This is marked as ready, but ideally would be home to some discussion / conversation about areas that might need some filters!
Lorekeeper is a bit of a beast as is, but funnily enough, does not have a consistent coverage of filtering

Areas Added Thus Far:

  • User and character inventories
  • User submissions
  • Loottables (admin panel)

@itinerare itinerare added enhancement New feature or request needs review Pull requests that are pending community review labels Sep 16, 2024
Copy link
Contributor

@SpeedyD SpeedyD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good at first glance, will give this a more solid review (and likely approval) when I got more time ^^;;

Copy link
Contributor

@SpeedyD SpeedyD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...yeah, I looked it over thoroughly and I STILL missed the fact that $artists wasn't defined. =_=;;

Eesh.. Good job catching and fixing that, Newt. Reapproved.

@itinerare
Copy link
Collaborator

Checking in with this one-- are you interested in adding more onto it, or should I just go ahead and merge?

@ScuffedNewt
Copy link
Contributor Author

I didnt think of any more myself, and I don't think anymore where suggested, so I think this is fine to merge as-is and if more search filters are requested down the line it should be easy to add in another PR!

@itinerare
Copy link
Collaborator

Makes sense to me!

@itinerare itinerare added reviewed Pull requests that have received community review and are pending merge and removed needs review Pull requests that are pending community review labels Oct 24, 2024
@itinerare itinerare merged commit 433913b into corowne:develop Oct 24, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request reviewed Pull requests that have received community review and are pending merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants