-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Extra / Nice-To-Have Filters #1064
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good at first glance, will give this a more solid review (and likely approval) when I got more time ^^;;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...yeah, I looked it over thoroughly and I STILL missed the fact that $artists wasn't defined. =_=;;
Eesh.. Good job catching and fixing that, Newt. Reapproved.
Checking in with this one-- are you interested in adding more onto it, or should I just go ahead and merge? |
I didnt think of any more myself, and I don't think anymore where suggested, so I think this is fine to merge as-is and if more search filters are requested down the line it should be easy to add in another PR! |
Makes sense to me! |
Adds some filters around the site!
This is marked as ready, but ideally would be home to some discussion / conversation about areas that might need some filters!
Lorekeeper is a bit of a beast as is, but funnily enough, does not have a consistent coverage of filtering
Areas Added Thus Far: