fix(subtypes): stop error on slots

[ScuffedNewt]

No description provided.

[SpeedyD]

.....Um, sorry, but what does this actually fix? Seems more like it's removing functionality.

[ScuffedNewt]

it fixes the slot tag
if you view the code the subtypes are treated differently further down, this code is unneeded since the subtype IDs are not contained in the character image

---

edit: adding some further clarification for anyone who may view this that I sent speedy in dms!
the subtype_ids should never have been present in the imageData because its not stored on the image table

for redesigns, the designUpdateManager puts the subtype_ids on the actual Request object, not on the image

further down in the code, there is an if(isset($data['subtype_ids']))... surrounding a forreach, this is the only needed part of the code

[ScuffedNewt]

you can test to see, but I had a few big reports across multiple sites - this has fixed it
edit: example bug report

this shows that its the fact that subtype_ids does not exist on the image table that is causing the error

[SpeedyD]

Right, fair enough. I think this error is primarily caused by the fact that that slot tags haven't been converted as did Design Updates and Character images, though new & edited slots shouldn't have this issue altogether.

On the other hand, the code does seem superfluous, as it's a relation now. It may be an issue for sites who have hard-coded a check for which image to use on subtypes, but that requires at most a check to fix.