feat(commands): improve second subtype support in subtype conversion command #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…command - make second subtype support work out of the box - add additional info text around design updates - add a progress bar for design updates
itinerare
added
bug
SpeedyD
approved these changes
Sep 2, 2024
ScuffedNewt
approved these changes
Sep 2, 2024
...Tbh Merc and I unanimously decided to do that in a seperate PR. XD |
|
I was thinking it made the most sense to get this in asap/make sure what's on the branch is known working, first, but otherwise yeah it's probably for the best |
itinerare
added
reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically emerged as a bugfix, but took the opportunity to put some polish on it and head off some future headaches while I was at it. Figured if there was already implicit support, explicit/out-of-the-box support was probably the better move and the one that keeps things simpler on the support front.
Tested both with and without second subtype columns, so shouldn't cause issues either way.