Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(admin): Admin Area Bootstrap tables (non-sortables) #1026

Merged

Conversation

SpeedyD
Copy link
Contributor

@SpeedyD SpeedyD commented Aug 23, 2024

Starting a minor project to get rid of all <table>s, to make them Bootstrap instead.

Files affected by this PR:

  • \resources\views\admin\sales\sales.blade.php
  • \resources\views\admin\users\user_update_log.blade.php
  • \resources\views\admin\staff_reward_settings.blade.php
  • \resources\views\admin\settings\settings.blade.php
  • \resources\views\admin\raffle\ticket_index.blade.php
  • \resources\views\admin\loot_tables_roll_loot_table.blade.php
  • \resources\views\admin\logs.blade.php
  • \resources\views\admin\files\index.blade.php

This particular PR does not cover pages that have sort functions, namely the following:

  • \resources\views\admin\submissions\submission.blade.php
  • \resources\views\admin\items\create_edit_item.blade.php
  • \resources\views\admin\users\ranks.blade.php
  • \resources\views\admin\sublist\sublist.blade.php
  • \resources\views\admin\specieses\subtypes.blade.php
  • \resources\views\admin\specieses\specieses.blade.php
  • \resources\views\admin\shops\shops.blade.php
  • \resources\views\admin\rarities\rarities.blade.php
  • \resources\views\admin\prompts\prompt_categories.blade.php
  • \resources\views\admin\items\item_categories.blade.php
  • \resources\views\admin\features\feature_categories.blade.php
  • \resources\views\admin\currencies\sort.blade.php
  • \resources\views\admin\characters\character_categories.blade.php

As well as \resources\views\admin\loot_tables\create_edit_loot_table.blade.php which is it's own little problem.

I intend to do another PR later for these.

@SpeedyD SpeedyD changed the title Fix(admin): Admin Area Bootstrap tables Fix(admin): Admin Area Bootstrap tables (non-sortables) Aug 24, 2024
@SpeedyD SpeedyD marked this pull request as ready for review August 24, 2024 14:35
@SpeedyD
Copy link
Contributor Author

SpeedyD commented Aug 24, 2024

I'm opting to make a different PR for the other files, as it will take a considerably longer time to get through, and I'd like to see the current set pushed prior.

@itinerare itinerare added bug Something isn't working needs review Pull requests that are pending community review labels Aug 24, 2024
Copy link
Contributor

@AW0005 AW0005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A thought on one, but otherwise looks all good

resources/views/admin/files/index.blade.php Outdated Show resolved Hide resolved
@ScuffedNewt
Copy link
Contributor

i will miss my tables... you are forcing my hand at finally understanding cols completely

@SpeedyD
Copy link
Contributor Author

SpeedyD commented Aug 27, 2024

i will miss my tables... you are forcing my hand at finally understanding cols completely

Eh, I still need to figure out the remaining files.. and whichever pages in public still use tables.. ;P

But that's a different PR, not this one. ^^;

@itinerare itinerare added reviewed Pull requests that have received community review and are pending merge and removed needs review Pull requests that are pending community review labels Aug 27, 2024
@itinerare itinerare merged commit 74ed3bf into corowne:release/v3.0.0 Aug 27, 2024
2 checks passed
@SpeedyD SpeedyD deleted the fix/admin-area-bootstrap-tables branch August 28, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working reviewed Pull requests that have received community review and are pending merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants